Orthanc Integration Tests & ARM Containers

Google Groups archive
1

Hi,

I have been working on a build pipeline to build arm containers based on the official https://github.com/orthanc-server/orthanc-builder repo.

I have the container builder and am working on getting the integration tests working. The current tests use the orthanc-tests repo and the https://hub.docker.com/r/jodogne/orthanc-tests container. This container is an x86 container so it doesn’t work. I built a new container to run the tests using the just built arm orthanc container which works.

The challenge I now have is that 6 tests are failing. It looks as though the tests expect the local running orthanc instance to be version 0.8.6. And as the tests are running 1.11.x both locally and remotely, the tests checking for expected failures caused by incompatibility with 0.8.6 (ie https://hg.orthanc-server.com/orthanc-tests/file/tip/Tests/Tests.py#l5957) fail. There are 6 like this.

I want to check a few things with the team before I continue:

  1. Am I right in thinking that the current integration tests expect the _LOCAL instance to be v 0.8.6?
  2. I see a 2 options to fix this:
    1. Disable the failing tests using pyunit options (if possible)
    2. Update the tests to check the version of the _LOCAL instance before running the assertions that expect an older _LOCAL version
      Does anyone have a thoughts or suggestions on the best way to do this for the long term?

Cheers,

James

2

Hi James,

Your assumption is correct, it assumes the _LOCAL instance is 0.8.6 (we wanted to test some kind of “backward” compatibility :slight_smile: ).

Your latest option (2.2) is clearly the best approach for the future. BTW, I have just implemented it and was able to run the tests with Orthanc 1.11.2 as the local Orthanc.

And thanks for working on the ARM Docker build !

Best regards,

Alain.