Hello
I’ trying to import few dicom from a folder , but always get error.
The dicom files are stored on D:\OrthancStorage (windows 10 machine)
The orthanc server is on IP 192.168.10.167:8042, is running, without username and password. (linux Debian machine)
Thanks in advance
Hello,
The “ImportDicomFiles.py” script must be called from the command-line shell (e.g. from bash), not from the Python interpreter:
https://book.orthanc-server.com/users/rest.html?highlight=importdicomfiles#sending-dicom-images
OK. It’s working. My mistake was when I downloaded the file ImportDicomFiles.py
I have trouble when I downloaded the file from bitbucket…
Thanks again
luni, 17 februarie 2020, 18:09:17 UTC+2, Sébastien Jodogne a scris:
Ι use the script in three different server setup, always when
“AuthenticationEnabled” : false and python ImportDicomFiles.py 127.0.0.1 8043 d is working fine, when “AuthenticationEnabled” : true
python ImportDicomFiles.py 127.0.0.1 8043 d: username password i am getting error connecting to server and script fail
windows 10 service 64bit
many thanks,
Kyriakos A D
Τη Δευτέρα, 17 Φεβρουαρίου 2020 - 11:00:01 π.μ. UTC+2, ο χρήστης Adrian Schiopu έγραψε:
Hello,
Is this a question?
If so, please provide clear explanations and a minimum working example for the Orthanc community to understand your issue:
https://book.orthanc-server.com/users/support.html#discussing-a-minimal-working-example
Sébastien-
Are you using Python 3 ? (I guess so) In that case, there are indeed issues when supplying user/password.
In that case, could you please give it a try with this script (I still need to find some time to make it Python-agnostic and submit it to Sébastien… right now I think the following only works with Python 3)
Be careful when copy/pasting, because Python is very nitpicky when it comes to indentation. The file is 4-space indented. You can diff the script with the original one to understand the issue.
Tell me if this works for you.
import os
import sys
import os.path
import httplib2
import base64
if len(sys.argv) != 4 and len(sys.argv) != 6:
print(“”"
Sample script to recursively import in Orthanc all the DICOM files
that are stored in some path. Please make sure that Orthanc is running
before starting this script. The files are uploaded through the REST
API.
Usage: %s [hostname] [HTTP port] [path]
Usage: %s [hostname] [HTTP port] [path] [username] [password]
For instance: %s 127.0.0.1 8042 .
“”" % (sys.argv[0], sys.argv[0], sys.argv[0]))
exit(-1)
URL = ‘http://%s:%d/instances’ % (sys.argv[1], int(sys.argv[2]))
success_count = 0
total_file_count = 0
def UploadFile(path):
global success_count
global total_file_count
f = open(path, “rb”)
content = f.read()
f.close()
total_file_count += 1
try:
sys.stdout.write(“Importing %s” % path)
h = httplib2.Http()
headers = { ‘content-type’ : ‘application/dicom’ }
if len(sys.argv) == 6:
username = sys.argv[4]
password = sys.argv[5]
creds_str = username + ‘:’ + password
creds_str_bytes = creds_str.encode(“ascii”)
creds_str_bytes_b64 = b’Basic ’ + base64.b64encode(creds_str_bytes)
headers[‘authorization’] = creds_str_bytes_b64.decode(“ascii”)
resp, content = h.request(URL, ‘POST’,
body = content,
headers = headers)
if resp.status == 200:
sys.stdout.write(" => success\n")
success_count += 1
else:
sys.stdout.write(" => failure (Is it a DICOM file? Is there a password?)\n")
except:
type, value, traceback = sys.exc_info()
sys.stderr.write(str(value))
sys.stdout.write(" => unable to connect (Is Orthanc running? Is there a password?)\n")
if os.path.isfile(sys.argv[3]):
UploadFile(sys.argv[3])
else:
for root, dirs, files in os.walk(sys.argv[3]):
for f in files:
UploadFile(os.path.join(root, f))
if success_count == total_file_count:
print(“\nSummary: all %d DICOM file(s) have been imported successfully” % success_count)
else:
print(“\nSummary: %d out of %d files have been imported successfully as DICOM instances” % (success_count, total_file_count))
Correct, I am using python3 in windows 10, i will check it later and i am going to inform
Many thanks,
Kyriakos A D
Τη Δευτέρα, 23 Μαρτίου 2020 - 3:33:00 μ.μ. UTC+2, ο χρήστης Benjamin Golinvaux έγραψε:
Your script is working fine with password authetication in all orthanc server setups i test it
The script is not working with password authetication in all orthanc server setups i test and working fine without pasword authetication is
#!/usr/bin/env python
If I understand correctly, your problem disappears when using my version of Sébastien’s script, right ?
(Sorry if I am not understanding correctly)
Yes, the authorisation problem disappears when using your version of the script
many thanks
Τη Δευτέρα, 23 Μαρτίου 2020 - 10:04:48 μ.μ. UTC+2, ο χρήστης Benjamin Golinvaux έγραψε:
Great! Glad to help.
As soon as I find some time, I’ll make sure to unify both scripts in a single Python 2 and 3 - compatible version.
The modified script can now be found in the Orthanc mainline, at the same location: /Resources/Samples/ImportDicomFiles/ImportDicomFiles.py