GDCM plugin 1.7

Dear all,

It is my pleasure to inform you that version 1.7 of the GDCM plugin for Orthanc has just been released.

This release bundles GDCM 3.0.24, which fixes three CVE that have recently been reported about GDCM: CVE-2024-22373, CVE-2024-22391, and CVE-2024-25569. Upgrade is thus recommended.

Regards,
Sébastien-

3 Likes

Thanks Sébastien !

This has been included in

Alain.

2 Likes

I just tried updating my Dockerfile to use 24.5.0-full instead of what I had previously, 24.4.0-full, and I got an error during the build:

E0511 08:43:22.516874             MAIN PluginsManager.cpp:153] The configuration option "PostgreSQL.EnableVerboseLogs" is not a Boolean as expected

The error goes away when I roll back that single change. Just wondering if that is related to the update ? I have the config in an .env file, and I changed only the Dockerfile image.

Hello Sebastien,
the plugin fails to build in Tumbleweed. I guess boost 1.85 is the bad guy…causes orthanc to fail as well.
See log: Welcome - openSUSE Build Service

What is the value of ORTHANC__POSTGRESQL__ENABLE_VERBOSE_LOGS in your env file ?
Before 24.5.0, this special env var was not defined and therefore, if you defined it, it did not end up at the right place and its validity was not checked.

…resp in full:
[ 38s] /var/lib/build/ccache/bin/c++ -DBOOST_ATOMIC_DYN_LINK -DBOOST_ATOMIC_NO_LIB -DBOOST_DATE_TIME_DYN_LINK -DBOOST_DATE_TIME_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_FILESYSTEM_NO_LIB -DBOOST_FILESYSTEM_VERSION=3 -DBOOST_HAS_FILESYSTEM_V3=1 -DBOOST_IOSTREAMS_DYN_LINK -DBOOST_IOSTREAMS_NO_LIB -DBOOST_REGEX_DYN_LINK -DBOOST_REGEX_NO_LIB -DBOOST_SYSTEM_DYN_LINK -DBOOST_SYSTEM_NO_LIB -DBOOST_THREAD_DYN_LINK -DBOOST_THREAD_NO_LIB -DHAS_ORTHANC_EXCEPTION=1 -DJSONCPP_DEPRECATED_STACK_LIMIT=5000 -DORTHANC_API_VERSION=23 -DORTHANC_BUILDING_FRAMEWORK_LIBRARY=0 -DORTHANC_DATABASE_VERSION=6 -DORTHANC_DEFAULT_DICOM_ENCODING=Encoding_Latin1 -DORTHANC_ENABLE_BASE64=1 -DORTHANC_ENABLE_CIVETWEB=0 -DORTHANC_ENABLE_CURL=0 -DORTHANC_ENABLE_DCMTK=0 -DORTHANC_ENABLE_DCMTK_JPEG=0 -DORTHANC_ENABLE_DCMTK_JPEG_LOSSLESS=0 -DORTHANC_ENABLE_DCMTK_NETWORKING=0 -DORTHANC_ENABLE_DCMTK_TRANSCODING=0 -DORTHANC_ENABLE_JPEG=0 -DORTHANC_ENABLE_LOCALE=0 -DORTHANC_ENABLE_LOGGING=1 -DORTHANC_ENABLE_LOGGING_PLUGIN=1 -DORTHANC_ENABLE_LOGGING_STDIO=0 -DORTHANC_ENABLE_LUA=0 -DORTHANC_ENABLE_MD5=1 -DORTHANC_ENABLE_MONGOOSE=0 -DORTHANC_ENABLE_PKCS11=0 -DORTHANC_ENABLE_PNG=0 -DORTHANC_ENABLE_PROTOBUF=0 -DORTHANC_ENABLE_PUGIXML=0 -DORTHANC_ENABLE_SQLITE=0 -DORTHANC_ENABLE_SSL=0 -DORTHANC_ENABLE_ZLIB=0 -DORTHANC_MAXIMUM_TAG_LENGTH=256 -DORTHANC_SANDBOXED=0 -DORTHANC_VERSION="1.12.3" -DORTHANC_VERSION_MAJOR=1 -DORTHANC_VERSION_MINOR=12 -DORTHANC_VERSION_REVISION=3 -DOrthancGdcm_EXPORTS -DPLUGIN_VERSION="1.7" -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE=1 -D__ORTHANC_FILE__="SystemToolbox.cpp" -I/home/abuild/rpmbuild/BUILD/OrthancGdcm-1.7/build/AUTOGENERATED -I/usr/src/orthanc/OrthancFramework/Sources -I/usr/lib64/usr/include/gdcm -I/home/abuild/rpmbuild/BUILD/OrthancGdcm-1.7/Resources/Orthanc/Sdk-1.7.0 -isystem /usr/include/gdcm -O2 -Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -Werror=return-type -flto=auto -Wall -Wno-long-long -Wno-variadic-macros -O2 -g -DNDEBUG -fPIC -MD -MT CMakeFiles/OrthancGdcm.dir/usr/src/orthanc/OrthancFramework/Sources/SystemToolbox.cpp.o -MF CMakeFiles/OrthancGdcm.dir/usr/src/orthanc/OrthancFramework/Sources/SystemToolbox.cpp.o.d -o CMakeFiles/OrthancGdcm.dir/usr/src/orthanc/OrthancFramework/Sources/SystemToolbox.cpp.o -c /usr/src/orthanc/OrthancFramework/Sources/SystemToolbox.cpp
[ 38s] /usr/src/orthanc/OrthancFramework/Sources/SystemToolbox.cpp: In static member function ‘static Orthanc::MimeType Orthanc::SystemToolbox::AutodetectMimeType(const std::string&)’:
[ 38s] /usr/src/orthanc/OrthancFramework/Sources/SystemToolbox.cpp:777:48: error: ‘extension’ is not a member of ‘boost::filesystem’
[ 38s] 777 | std::string extension = boost::filesystem::extension(path);
[ 38s] | ^~~~~~~~~
[ 38s] make[2]: *** [CMakeFiles/OrthancGdcm.dir/build.make:709: CMakeFiles/OrthancGdcm.dir/usr/src/orthanc/OrthancFramework/Sources/SystemToolbox.cpp.o] Error 1
[ 38s] make[2]: Leaving directory ‘/home/abuild/rpmbuild/BUILD/OrthancGdcm-1.7/build’
[ 38s] make[1]: *** [CMakeFiles/Makefile2:86: CMakeFiles/OrthancGdcm.dir/all] Error 2
[ 38s] make: *** [Makefile:139: all] Error 2
[ 38s] error: Bad exit status from /var/tmp/rpm-tmp.k81xeR (%build)

Thank you. I’ll check and try building it again. It seems that it might be a syntax issue:

ORTHANC__POSTGRESQL__ENABLE_VERBOSE_LOGS=“false” vs. “False” evaluate differently. Is lower case required in the .env ?

Hello Axel,

Thanks for the report. This has been fixed in the mainline of Orthanc by the following patch: orthanc: a7c88563c8cc

Kind Regards,
Sébastien-

yes

1 Like