Compilation error in Webviewer CacheManager.cpp

Hi,

I run into a compilation error for the WebViewer Plugin:

[   85s] In file included from /home/abuild/rpmbuild/BUILD/OrthancWebViewer-2.5/Plugin/Cache/CacheManager.cpp:22:
[   85s] /home/abuild/rpmbuild/BUILD/OrthancWebViewer-2.5/Plugin/Cache/CacheManager.h:42:30: error: field 'pimpl_' has incomplete type 'boost::shared_ptr<OrthancPlugins::CacheManager::PImpl>'
[   85s]    42 |     boost::shared_ptr<PImpl> pimpl_;
[   85s]       |                              ^~~~~~
[   85s] In file included from /usr/include/boost/throw_exception.hpp:36,
[   85s]                  from /usr/include/boost/lexical_cast/bad_lexical_cast.hpp:28,
[   85s]                  from /usr/include/boost/lexical_cast.hpp:31,
[   85s]                  from /usr/src/orthanc/Resources/CMake/../../Core/SQLite/../Logging.h:60,
[   85s]                  from /usr/src/orthanc/Resources/CMake/../../Core/SQLite/../OrthancException.h:37,
[   85s]                  from /usr/src/orthanc/Resources/CMake/../../Core/SQLite/OrthancSQLiteException.h:152,
[   85s]                  from /usr/src/orthanc/Resources/CMake/../../Core/SQLite/Statement.h:41,
[   85s]                  from /usr/src/orthanc/Resources/CMake/../../Core/SQLite/Connection.h:40,
[   85s]                  from /home/abuild/rpmbuild/BUILD/OrthancWebViewer-2.5/Plugin/Cache/CacheManager.h:24,
[   85s]                  from /home/abuild/rpmbuild/BUILD/OrthancWebViewer-2.5/Plugin/Cache/CacheManager.cpp:22:
[   85s] /usr/include/boost/exception/exception.hpp:15:44: note: declaration of 'class boost::shared_ptr<OrthancPlugins::CacheManager::PImpl>'
[   85s]    15 | namespace boost { template <class T> class shared_ptr; }
[   85s]       |                                            ^~~~~~~~~~
[   85s] /home/abuild/rpmbuild/BUILD/OrthancWebViewer-2.5/Plugin/Cache/CacheManager.cpp: In member function 'OrthancPlugins::CacheManager::Bundle OrthancPlugins::CacheManager::GetBundle(int) const':
[   85s] /home/abuild/rpmbuild/BUILD/OrthancWebViewer-2.5/Plugin/Cache/CacheManager.cpp:178:3: error: control reaches end of non-void function [-Werror=return-type]
[   85s]   178 |   }
[   85s]       |   ^

Full log: https://build.opensuse.org/package/live_build_log/home:DocB:Orthanc/orthanc-webviewer/openSUSE_Tumbleweed/x86_64

Any hints?

Thx
Axel

Hello,

Please could you have a try with the following patch?
https://bitbucket.org/sjodogne/orthanc-webviewer/commits/3aae28985514f10192874b242dcdeb1ba8a68228

BR,
S├ębastien-

Hi Sebastien,