16bit RGBA PNG Support

Google Groups archive
1

Hi Orthanc Team,

Please find attached a patch to allow the create-dicom endpoint to accept 16bit RGBA PNGs. There are 3 files attached:

  1. Patch for the main Orthanc repo
  2. Patch for the orthanc-tests repo
  3. Example PNG file for testing
    I have tested this locally with different images as well as the attached one.

This is stretching my knowledge of C++ so any feedback is welcome.

Cheers,

James

orthanc-tests-png-rgba16.patch (2.16 KB)

orthanc-png-rgba16.patch (12.8 KB)

Png16RBGATest.png

2

Hi James,

Thanks a lot for that. >From a first glance that looks pretty good ! And, there even are unit and integration tests so you’re close to perfection :slight_smile: !

I’ll integrate that ASAP.

Best regards,

Alain.

3

Hi James,

I have reviewed your code and integrated it as is in our repositories:
https://hg.orthanc-server.com/orthanc/rev/255b02c68908

https://hg.orthanc-server.com/orthanc-tests/rev/e904b2282b0e

Thanks again for your contribution.

Alain.