Various Build failures (framework 1.2.10, boost)

General
1

Hello,

I noted various build failures since recent updates:

orthanc-wsi 3.3 fails to build since update to orthanc framework 1.12.10:

[   39s] /home/abuild/rpmbuild/BUILD/orthanc-wsi-3.3-build/OrthancWSI-3.3/Framework/Outputs/MultiframeDicomWriter.cpp: In member function ‘void OrthancWSI::MultiframeDicomWriter::Flush(std::string&, unsigned int)’:
[   39s] /home/abuild/rpmbuild/BUILD/orthanc-wsi-3.3-build/OrthancWSI-3.3/Framework/Outputs/MultiframeDicomWriter.cpp:341:31: error: no matching function for call to ‘Orthanc::DcmtkTranscoder::Transcode(Orthanc::IDicomTranscoder::DicomImage&, Orthanc::IDicomTranscoder::DicomImage&, std::set<Orthanc::DicomTransferSyntax>&, bool)’

See full log: https://build.opensuse.org/package/live_build_log/graphics/orthanc-wsi/16.0/x86_64

Nearly all packages fail to build with boost 1.89, as libboost_system was removed, and packages still looking for this configuration option. This affects (at least)

gdcm
indexer
mysql
neuro
ohif
stl
tcia
webviewer

Any ideas?

2

Hello,

Check out the modification to Framework/Outputs/MultiframeDicomWriter.cpp contained in this patch: orthanc-wsi: 4fa295cdb6d8

This is a typical case where package maintainers have to manually apply a patch to fix the build on their GNU/Linux distributions, until the issue can be fixed upstream. We cannot continuously update to new versions of third-party dependencies, this would be a full-time job.

Just remove system from the find_package() invocation in the CMakeLists.txt files of each of these packages (for instance, here is the direct link for orthanc-stl).

Kind Regards,
Sébastien-

3

Additional information: I’ve committed a lot of updates to the packages you listed that should help you fix the openSUSE packages. Make sure to have a look at the recent modifications to our source code repositories.

4

Thank you Sebastien

Actually it needs to be patched out in orthanc 1.12.10 as well

5

This is already done: orthanc: 770d6037b79f

However, we cannot afford making a new release only for this minor modification that can be patched by downstream package maintainers. The release process of the Orthanc core takes about one day given our thorough quality control procedure.

6

good to see

Sure, and no problem. it is a one-liner using sed in the spec file