Tiny bug in dicomweb 1.0 plugin

Hello,

I’m not new to Orthanc, but this is my first posting to community. I recently stumbled across a tiny bug in the dicomweb 1.0 plugin in the Configuration.cpp source. Specifically line 442 in the LookupHttpHeader2 static method

https://bitbucket.org/sjodogne/orthanc-dicomweb/src/9db71a9d0d8ba73921ddcaba68687cd4111588c1/Plugin/Configuration.cpp#lines-442

The line should be

return true;

It’s likely a typo that causes the method to always return false even if the searched for http header is found.

It has the effect (among other things) of causing qido-rs responses that include the service base IP address/port to always contain the default value of “localhost:8042”

Thank you to Sébastien and the rest of the Orthanc contributors,

Mark

Hello,

Thanks for your investigation and your reporting a fix!

The patch is now committed in the mainline:
https://bitbucket.org/sjodogne/orthanc-dicomweb/commits/351db3241ea64fac7a9a8f954dfa10630ef4126d

Regards,
Sébastien-