Question about the 'UNLOCK=true will start Orthanc with the --unlock option for Osimis'

Google Groups archive
1

I was looking at one of my dev servers and noticed a warning regarding unlock because I had a remnant from a previous config. Apparently --unlock is not a valid option.

environment:
UNLOCK: “true”
VERBOSE_ENABLED: “true”
VERBOSE_STARTUP: “true”

It is mentioned here in the book:

https://book.orthanc-server.com/users/docker-osimis.html?highlight=unlock#special-environment-variables

Is that actually a startup option like trace and verbose, or does that pertain to a DB configuration as in:

{
“PostgreSQL”: {
“EnableIndex”: true,
“EnableStorage”: false,
“Port”: 5432,
“Host”: “HOST MUST BE DEFINED”,
“Database”: “postgres”,
“Username”: “postgres”,
“Password”: “postgres”,
“EnableSsl”: false,
“Lock”: false
}

}

so it might be something like:

ORTHANC__POSTGRESQL__LOCK: true/false

2

What I see in the log is:

W1125 03:55:43.202700 main.cpp:1930] Option unsupported by the core of Orthanc: --unlock

and the docker-entrypoint.sh has:

unlock=“”
if [[ $UNLOCK == true ]]; then
unlock=–unlock
fi

if [[ ! -z $BEFORE_ORTHANC_STARTUP_SCRIPT ]]; then
echo “running custom startup script”
$BEFORE_ORTHANC_STARTUP_SCRIPT
fi

argv=(Orthanc $verbosity $logoption $jobs $unlock “$@”)
echo “Startup command: ${argv[*]}” >&2
exec “${argv[@]}”

3

I confirm that the “–unlock” command-line options is now useless, as it was only used by an early version of the PostgreSQL plugin (before its 1.0 release).

For reference, here is the changeset from 2015 that has removed its need, by replacing the early locking mechanism based on global properties, by a (much cleaner) PostgreSQL advisory lock:
https://hg.orthanc-server.com/orthanc-postgresql/rev/401684ea8d73

As suggested, I have just removed the “UNLOCK” environment variable for future versions of the Osimis image:
https://bitbucket.org/osimis/orthanc-builder/commits/4e649ead83ec30efd1730079e4c9fe5be549a182