OrthancMySQL-1.1 with Orthanc 1.5.0

Google Groups archive
1

hi, is it possible that the MySQL plugin is not compatible with Orthanc 1.5.0 yet?
if i try to compile i get

aydin@…:/opt/OrthancMySQL-1.1/build$ make all

Scanning dependencies of target OrthancMySQLStorage
[ 0%] Building CXX object CMakeFiles/OrthancMySQLStorage.dir/opt/OrthancMySQL-1.1/Framework/Plugins/PluginInitialization.cpp.o
[ 0%] Building CXX object CMakeFiles/OrthancMySQLStorage.dir/Plugins/MySQLStorageArea.cpp.o
[ 0%] Building CXX object CMakeFiles/OrthancMySQLStorage.dir/Plugins/StoragePlugin.cpp.o
/opt/OrthancMySQL-1.1/MySQL/Plugins/StoragePlugin.cpp: In function ‘int32_t OrthancPluginInitialize(OrthancPluginContext*)’:
/opt/OrthancMySQL-1.1/MySQL/Plugins/StoragePlugin.cpp:43:63: error: no matching function for call to ‘OrthancPlugins::OrthancConfiguration::OrthancConfiguration(OrthancPluginContext*&)’
OrthancPlugins::OrthancConfiguration configuration(context);
^
In file included from /opt/OrthancMySQL-1.1/MySQL/Plugins/…/…/Framework/MySQL/MySQLParameters.h:28:0,
from /opt/OrthancMySQL-1.1/MySQL/Plugins/MySQLStorageArea.h:25,
from /opt/OrthancMySQL-1.1/MySQL/Plugins/StoragePlugin.cpp:22:
/opt/Orthanc-1.5.0/Resources/CMake/…/…/Plugins/Samples/Common/OrthancPluginCppWrapper.h:265:5: note: candidate: OrthancPlugins::OrthancConfiguration::OrthancConfiguration()
OrthancConfiguration();
^~~~~~~~~~~~~~~~~~~~
/opt/Orthanc-1.5.0/Resources/CMake/…/…/Plugins/Samples/Common/OrthancPluginCppWrapper.h:265:5: note: candidate expects 0 arguments, 1 provided
CMakeFiles/OrthancMySQLStorage.dir/build.make:118: recipe for target ‘CMakeFiles/OrthancMySQLStorage.dir/Plugins/StoragePlugin.cpp.o’ failed
make[2]: *** [CMakeFiles/OrthancMySQLStorage.dir/Plugins/StoragePlugin.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target ‘CMakeFiles/OrthancMySQLStorage.dir/all’ failed
make[1]: *** [CMakeFiles/OrthancMySQLStorage.dir/all] Error 2
Makefile:129: recipe for target ‘all’ failed
make: *** [all] Error 2

is this on my side only?

2

I have just tried, and it does compile.

Here is the CMake invocation I used on “OrthancMySQL-1.1.tar.gz”:

cmake /tmp/OrthancMySQL-1.1/MySQL/ -DALLOW_DOWNLOADS=ON -DUSE_SYSTEM_ORTHANC_SDK=OFF -DUSE_SYSTEM_GOOGLE_TEST=OFF -DCMAKE_BUILD_TYPE=Debug

Please remove your build directory, and start again with a fresh build.

3

ok, sorry, i cleaned up the whole build directory and now it works.
(its a hassle with our setup because we dont have internect connection on the orthanc machine,
so i tried not to clean up everything and such)

thanks!

4

i am sorry to ask, but now i realize that your invocation seems to be using the Orthanc-1.4 sources,
this is probably why it is not throwing an error.

so it is safe to use the plugin compiled for 1.4 on orthanc 1.5?
in this case i dont need to recompile anyway.

5

Yes, once a plugin is compiled, it will work on all future versions of Orthanc.

In any way, the plugin would refuse to start if it is incompatible with the version of its hosting Orthanc server.