I there a way you could include this “script change” to a vendor specific option ?
The problem I have is that we try to build a connection between orthanc and our homemade PET/CT viewer. So I’m going to teach physician in a setup guide how to install Orthanc to get all Orthanc’s features along with our PET/CT viewer in Fiji. It is a bit complicated to teach them to install a Lua script.
I’m going to try to see if it is the same “*” problem for the Philips workstation in Dijon (but since i’m 600 km away it is much harder).
That way I could tell you if it is something applicable to Philips manufacturer too.
I'm happy to post here my final solution, now I have bi-directionnal query working for both GE (Xeleris and AWserver) and Philips (the 2 versions of the ADW workstation).
I made 2 Lua scripts, 1 for the ORTHANC=>Commercial station query and 1 other for the Commercial station => ORTHANC query.
These 2 scripts fix both GE and Philips.
I hope this will allow you to add the specific vendor tag for the next versions of Orthanc.
function OutgoingFindRequestFilter(query, modality)
for key, value in pairs(query) do
if value == '*' then
query[key] = ''
end
end
return query
end
- To fix the query from GE/Philips to ORTHANC, I had to erase 3 tags as follow :
function IncomingFindRequestFilter(query, origin)
-- First display the content of the C-Find query
PrintRecursive(query)
PrintRecursive(origin)
-- Remove the "PrivateCreator" tag from the query
local v = query
-- generic group lenght
v['0008,0000'] = nil
v['0010,0000'] = nil
v['0020,0000'] = nil
return v
What version are you using ? If you are using an older version. That would be great if you could test with v1.2.0 (and without your IncomingFindRequestFilter callback).
Sorry, the patch I pointed you on was used only in the ModalityWorklist plugin, not in the standard C-Find.
I think we may ignore the group-length tags in any case. I’ll check with Sebastien if we should apply this to all modalities (it does not make much sense to compare length in queries with length in dicom files).
Note that these 3 length tags are already ignored for “eFilm2” modalities. If we don’t ignore all group-length, we’ll introduce new modality types for yours.
About the outgoing requests, there is already this kind of hack for the “AgfaImpax” modality. Can you check it works if you define your modality as “AgfaImpax” ?
Can you give us the exact name of your Philips modality ? “Philips” might be too generic for the configuration file.
The Efilm2 option correctly fix the incoming requests (GE to Orthanc)
But the AgfaImpax do not fix the outgoing request (Orthanc to GE).
If I refer to this post (https://groups.google.com/d/msg/orthanc-users/_Tw7J8s31Ho/vXIMiGDfdxoJ) the '*' erase was discussed patient birth date while my script replaced all the '*' by '' (for all tags). Maybe that is why this AgfaImpax is still not solving my queries ?
For Philips, it is "ADW" workstation
For GE, the patches fix both "Xeleris" which is GE software for conventional scintigraphy and "AWServer" which is the newer server application provided by GE which merge many post-processing software (PET/CT, CT and probably MRI).
Don't hesitate if you need more data, it is a pleasure to contribute.
, I have a problem, I cannot restore images stored in orthanc to AWServer But I can recover it using console mri or ct